Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [BUG] Fix Aggregator does not retrieve unpublished Tour Steps (#3569) #4300

Merged
merged 1 commit into from
Sep 16, 2024
Merged

🐛 [BUG] Fix Aggregator does not retrieve unpublished Tour Steps (#3569) #4300

merged 1 commit into from
Sep 16, 2024

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Sep 9, 2024 •
edited
Loading

Description

Retrieve steps that are not published for a published trek in agregator

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@Chatewgne Chatewgne changed the title 🐛 [BUG] Fix Aggregator does not retrieve unpublished Tour Steps (refs… 🐛 [BUG] Fix Aggregator does not retrieve unpublished Tour Steps (#3569) Sep 9, 2024
@Chatewgne Chatewgne force-pushed the fix_agreg_route_unpublished_steps branch 2 times, most recently from 34a0f8d to 23cbd00 Compare September 9, 2024 15:08
@cypress Cypress
Copy link

cypress bot commented Sep 9, 2024 •
edited
Loading

Geotrek-admin    Run #9905

Run Properties:  status check passed Passed #9905  •  git commit de6b930c2d ℹ️: Merge 83edea0fab19b8e70ee71c8386af5474e6a532b9 into 6c41bd4ad61c2bdf001108fc3deb...
Project Geotrek-admin
Branch Review refs/pull/4300/merge
Run status status check passed Passed #9905
Run duration 02m 01s
Commit git commit de6b930c2d ℹ️: Merge 83edea0fab19b8e70ee71c8386af5474e6a532b9 into 6c41bd4ad61c2bdf001108fc3deb...
Committer Célia
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@Chatewgne Chatewgne force-pushed the fix_agreg_route_unpublished_steps branch 5 times, most recently from b07cc35 to fa8ede4 Compare September 13, 2024 13:48
@Chatewgne Chatewgne force-pushed the fix_agreg_route_unpublished_steps branch from fa8ede4 to 83edea0 Compare September 13, 2024 13:53
@codecov Codecov
Copy link

codecov bot commented Sep 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (2aeaf05) to head (83edea0).
Report is 14 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4300   +/-   ##
=======================================
  Coverage   98.38%   98.39%           
=======================================
  Files         267      267           
  Lines       20916    20915    -1     
=======================================
+ Hits        20579    20580    +1     
+ Misses        337      335    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

marcantoinedupre
marcantoinedupre approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@marcantoinedupre marcantoinedupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Je valide la bascule vers le GET de chaque itinéraire étape avec son ID via l'API du Geotrek source.
J'ai survolé les changements dans les tests.

@Chatewgne Chatewgne merged commit a14910b into master Sep 16, 2024
18 checks passed
@Chatewgne Chatewgne deleted the fix_agreg_route_unpublished_steps branch September 16, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcantoinedupre marcantoinedupre marcantoinedupre approved these changes

Assignees
No one assigned
Labels
🐛 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chatewgne @marcantoinedupre